|
|
|
08/20/2008, 10:29 PM
|
#1 |
|
Registered Member
Join Date: Mar 2007
Location: Jacksonville, FL
Posts: 87
|
Code Review Please
Figure I would post this to help others and see if others can point out any flaws in my logic. Thank you
MHL$-A1 LT5$-A2 HTR%-A3 CO2&-A4 MHR$-A5 RTN#-A6 UVL$-A7 PM1#-A8 If Time > 00:00 Then RTN ON If Time > 00:00 Then PM1 ON If Time > 00:00 Then UVL ON If Temp < RT+-1.0 Then HTR ON If Temp > RT+0.0 Then HTR OFF If Temp < 70.0 Then HTR OFF If Temp > 83.00 Then MHL OFF Max Change 020 M Then MHL OFF If Temp > 83.00 Then MHR OFF Max Change 020 M Then MHR OFF If Temp > 83.00 Then UVL OFF Max Change 010 M Then UVL OFF If Temp > 84.00 Then LT5 OFF Max Change 015 M Then LT5 OFF If Sun 000/000 Then LT5 ON If Time > 08:00 Then MHL ON If Time > 14:00 Then MHL OFF If Time > 08:00 Then MHR ON If Time > 14:00 Then MHR OFF If Time > 08:00 Then UVL OFF If Time > 20:00 Then UVL ON If pH > 08.40 Then CO2 ON If pH < 08.35 Then CO2 OFF If Power 025 Then MHL OFF If Power 025 Then MHR OFF If Power 015 Then LT5 OFF If FeedA 000 Then RTN OFF If FeedB 005 Then PM1 OFF If FeedB 020 Then RTN OFF
__________________
-Chuck Current Tank Info: 70g Oceanic Tech Tank |
|
|
|
08/21/2008, 12:05 PM
|
#2 |
|
RC Sponsor
 Join Date: Aug 2001
Location: San Jose, CA
Posts: 4,311
|
You need to change the order of the light shutdown statements when the temperature gets too high. The order doesn't really matter for the 'If Time' statements as 'If Time' statements are always executed first no matter where they are in the program. But the 'If Sun' needs to be first so that it is lower priority. Use this program instead:
If Time > 00:00 Then RTN ON If Time > 00:00 Then PM1 ON If Time > 00:00 Then UVL ON If Temp < RT+-1.0 Then HTR ON If Temp > RT+0.0 Then HTR OFF If Temp < 70.0 Then HTR OFF If Sun 000/000 Then LT5 ON If Time > 08:00 Then MHL ON If Time > 14:00 Then MHL OFF If Time > 08:00 Then MHR ON If Time > 14:00 Then MHR OFF If Time > 08:00 Then UVL OFF If Time > 20:00 Then UVL ON If pH > 08.40 Then CO2 ON If pH < 08.35 Then CO2 OFF If Temp > 83.00 Then MHL OFF Max Change 020 M Then MHL OFF If Temp > 83.00 Then MHR OFF Max Change 020 M Then MHR OFF If Temp > 83.00 Then UVL OFF Max Change 010 M Then UVL OFF If Temp > 84.00 Then LT5 OFF Max Change 015 M Then LT5 OFF If Power 025 Then MHL OFF If Power 025 Then MHR OFF If Power 015 Then LT5 OFF If FeedA 000 Then RTN OFF If FeedB 005 Then PM1 OFF If FeedB 020 Then RTN OFF Curt |
|
|
|
 |
| Thread Tools | |
|
|
